fix(core): remove duplicate initialize call on agents refreshed#25670
fix(core): remove duplicate initialize call on agents refreshed#25670adamfweidman wants to merge 4 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where agent reloading caused redundant initialization calls, leading to errors in the A2AClientManager. By removing the unnecessary call in the configuration handler, the system now correctly manages agent states during refresh events without triggering duplicate load operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
Size Change: +307 B (0%) Total Size: 33.6 MB
ℹ️ View Unchanged
|
Replaced the hacky invocation of the private `onAgentsRefreshed` method with the correct public API `getAgentRegistry().reload()` in the config-agents-reload tests. This aligns the tests with the intended architecture where the registry manages its own state and emits an event upon reload, which the Config then reacts to.
1 participant
Summary
Fixed duplicate call to
loadAgentsduring/agents reloadand similar events.Fixed Streaming.
Details
Removed the call to
initialize()inonAgentsRefreshedinpackages/core/src/config/config.ts. Previously, this handler calledinitialize(), which in turn calledloadAgents()again. Sincereload()already callsloadAgents(), this was redundant and caused "already loaded" errors for remote agents inA2AClientManager.This issue was introduced in PR #24489 during the subagent tool refactoring.
Related Issues
Fixes the issue where
/agents reloadthrows 'already loaded' errors for remote agents.How to Validate
/agents reloadin the CLI.Pre-Merge Checklist